Skip to content

Use KNITRO_jll in README and update MINLPTests/Project.toml#203

Merged
odow merged 5 commits into
masterfrom
od/readme
Oct 29, 2025
Merged

Use KNITRO_jll in README and update MINLPTests/Project.toml#203
odow merged 5 commits into
masterfrom
od/readme

Conversation

@odow

@odow odow commented Oct 29, 2025

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Oct 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.83%. Comparing base (7b6cbc1) to head (6443815).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #203   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files           1        1           
  Lines          86       86           
=======================================
  Hits           85       85           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odow

odow commented Oct 29, 2025

Copy link
Copy Markdown
Member Author

@amontoison @cvanaret why does Uno fail so many tests here?

@odow

odow commented Oct 29, 2025

Copy link
Copy Markdown
Member Author

I see there are lots of non-default options that are set:

https://github.com/cvanaret/Uno/blob/3e926fda76aef253e4a582d517ffb691cf0415f2/.github/julia/runtests_uno_filterslp_bqpd.jl#L25

What is the default preset? These tests in MINLPTests should not be difficult to pass.

@amontoison

amontoison commented Oct 29, 2025

Copy link
Copy Markdown
Collaborator

@odow The issue is HiGHS v1.12, it breaks a lot of tests in Uno.
We keep the version v1.11 for CI in the repository of Uno for now.

The new release of HiGHS should be non-breaking (minor version) but it impacted us somehow.
I didn't investigated yet.

Comment thread test/MINLPTests/Project.toml Outdated
MINLPTests = "0.6"
SHOT_jll = "100.100.0"
Uno_jll = "1"
Uno_jll = "2"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We fixed so many bugs before that I highly suggest 2.3.0.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is with Uno@2.3.0

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I just want to be sure that the tests here are always using Uno >= 2.3.0 in the future.

@cvanaret

Copy link
Copy Markdown
Contributor

I see there are lots of non-default options that are set:

https://github.com/cvanaret/Uno/blob/3e926fda76aef253e4a582d517ffb691cf0415f2/.github/julia/runtests_uno_filterslp_bqpd.jl#L25

What is the default preset? These tests in MINLPTests should not be difficult to pass.

The default preset is filtersqp, but we're also testing other combinations of strategies in CI (barrier, SLP, with identity Hessian, and so on).

@odow

odow commented Oct 29, 2025

Copy link
Copy Markdown
Member Author

The issue is HiGHS v1.12, it breaks a lot of tests in Uno.

Ah, this is probably it

@odow

odow commented Oct 29, 2025

Copy link
Copy Markdown
Member Author

Ah, this is probably it

This was not it

@amontoison

Copy link
Copy Markdown
Collaborator

@odow I found the test files that did Charlie for the AMPL interface:
https://github.com/cvanaret/Uno/tree/main/.github/julia

Maybe we exclude some tests that you don't exclude here.

@odow

odow commented Oct 29, 2025

Copy link
Copy Markdown
Member Author

@cvanaret

Copy link
Copy Markdown
Contributor

Yeah unfortunately each test set is tailored to the particular Uno method...

Comment thread test/MINLPTests/run_minlptests.jl Outdated
@odow

odow commented Oct 29, 2025

Copy link
Copy Markdown
Member Author

At this point I just removed Uno from the tests. If you're testing upstream, you can control which tests to skip etc. There's no need to repeat things here.

@odow odow merged commit b4cd7c4 into master Oct 29, 2025
15 checks passed
@odow odow deleted the od/readme branch October 29, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants