Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #203 +/- ##
=======================================
Coverage 98.83% 98.83%
=======================================
Files 1 1
Lines 86 86
=======================================
Hits 85 85
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@amontoison @cvanaret why does Uno fail so many tests here? |
|
I see there are lots of non-default options that are set: What is the default preset? These tests in MINLPTests should not be difficult to pass. |
|
@odow The issue is HiGHS v1.12, it breaks a lot of tests in Uno. The new release of HiGHS should be non-breaking (minor version) but it impacted us somehow. |
| MINLPTests = "0.6" | ||
| SHOT_jll = "100.100.0" | ||
| Uno_jll = "1" | ||
| Uno_jll = "2" |
There was a problem hiding this comment.
We fixed so many bugs before that I highly suggest 2.3.0.
There was a problem hiding this comment.
Yes, I just want to be sure that the tests here are always using Uno >= 2.3.0 in the future.
The default preset is |
Ah, this is probably it |
This was not it |
|
@odow I found the test files that did Charlie for the AMPL interface: Maybe we exclude some tests that you don't exclude here. |
|
The answer is that you're just excluding a bunch of tests locally: https://github.com/cvanaret/Uno/blob/3e926fda76aef253e4a582d517ffb691cf0415f2/.github/julia/runtests_uno_filtersqp_bqpd.jl#L38-L45 |
|
Yeah unfortunately each test set is tailored to the particular Uno method... |
|
At this point I just removed Uno from the tests. If you're testing upstream, you can control which tests to skip etc. There's no need to repeat things here. |
No description provided.