feat: put notification bell behind a WAC flag#2835
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThe PR adds a ChangesNotification Feature Gating
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Review rate limit: 4/5 reviews remaining, refill in 12 minutes. Comment |
|
✅ All snapshot tests passed |
Playwright test resultsDetails
Flaky testschromium › landingPage.spec.ts › Landing page and navigation › Should navigate to the homepage and change tabs (Qase ID: 2) Skipped testschromium › themeManipulation.spec.ts › Switch between dark and light theme and check the background color › Partner theme should appear in theme menu and apply background color (Qase ID: 49) |
cc5e8d1 to
c8f77f7
Compare
c8f77f7 to
9c9ae71
Compare
9c9ae71 to
7f57d79
Compare
NOTE this is in draft as it's based on https://github.com/jumperexchange/strapi-cms/pull/107
Which Jira task belongs to this PR?
https://linear.app/lifi-linear/issue/JUM-722/strapi-based-feature-flag-to-activate-notifications-for-a-subset-of
Why did I implement it this way?
The gatekeeper was already used for Earn so I could just re-use the existing logic.
Checklist before requesting a review
Summary by CodeRabbit
New Features
Chores