perf: fix websftp root account folder locked #1955
Conversation
| } | ||
| if ad.isRoot && ad.info.IsDir() { | ||
| return ad.info.Mode() | os.ModePerm | ||
| } |
There was a problem hiding this comment.
There were no found differences or irregularities between the two versions of the provided code snippet. Both versions seem to be consistent with the context provided, and there is nothing that could potentially cause bugs or problems.
However, since I do not see any issues right away, it might be worth considering if you're dealing with real production code where every function may have its own unique set of requirements and constraints which need careful examination especially when compared over time.
Also consider that these files are from the last year but they should still follow the standard coding practices applicable today such as using Go's built-in os.ModeType which would align better than trying to manually define permissions this way even though the first version did not return os.FileMode. In addition, using os.ModeMask in conjunction with o.Syscall() rather than doing an explicit mode cast can yield cleaner looking errors like err != nil, instead of being limited to just "no error" conditions without knowing what went wrong precisely.
For instance,
return ret.Call("open", "/path/to/folder/path")
Would more clearly explain why open syscall failed because opening directories in Linux has different semantics than Windows due to the concept of a 'root' user.
|
perf: fix websftp root account folder locked