Repository navigation
fix: share session page not load favicon - #1519
Merged
Merged
Conversation
|
baijiangjie
reviewed
Apr 14, 2026
| } | ||
|
|
||
| declare module 'sm-crypto'; | ||
| declare module 'crypto-js'; |
Member
There was a problem hiding this comment.
不声明时，开发环境 yarn dev 起不来，找不到 module。
baijiangjie
reviewed
Apr 14, 2026
| constructor( | ||
| _i18n: I18nService, | ||
| private eventManager: EventManager, | ||
| _setting: SettingService |
Member
There was a problem hiding this comment.
不初始化时，/share/... 路径下的 favicon 不能加载，因为 public-settings 没有获取。
ibuler
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: share session page not load favicon