Skip to content

perf: update connect acl dialog - #1564

Merged
ibuler merged 1 commit into
devfrom
pr@dev@perf_acl_dialog
Aug 6, 2026
Merged

perf: update connect acl dialog#1564
ibuler merged 1 commit into
devfrom
pr@dev@perf_acl_dialog

perf: update connect acl dialog

2489a8f
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Aug 5, 2026 in 25s

Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 42 in src/app/services/connect-token/batch-acl-dialog/batch-acl-dialog.component.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark these members as `readonly`.

See more on https://sonarcloud.io/project/issues?id=jumpserver_luna&issues=AZ_Qqcr1HqrTAqYRdKEG&open=AZ_Qqcr1HqrTAqYRdKEG&pullRequest=1564

Check warning on line 123 in src/app/services/connect-token/batch-acl-dialog/batch-acl-dialog.component.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read.

See more on https://sonarcloud.io/project/issues?id=jumpserver_luna&issues=AZ_Qqcr2HqrTAqYRdKEK&open=AZ_Qqcr2HqrTAqYRdKEK&pullRequest=1564

Check failure on line 267 in src/app/services/connect-token/batch-acl-dialog/batch-acl-dialog.component.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure disabling Angular built-in sanitization is safe here.

See more on https://sonarcloud.io/project/issues?id=jumpserver_luna&issues=AZ_Qqcr2HqrTAqYRdKEL&open=AZ_Qqcr2HqrTAqYRdKEL&pullRequest=1564

Check warning on line 106 in src/app/services/connect-token/batch-acl-dialog/batch-acl-dialog.component.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read.

See more on https://sonarcloud.io/project/issues?id=jumpserver_luna&issues=AZ_Qqcr2HqrTAqYRdKEI&open=AZ_Qqcr2HqrTAqYRdKEI&pullRequest=1564

Check warning on line 40 in src/app/services/connect-token/batch-acl-dialog/batch-acl-dialog.component.html

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a "title" attribute to this <iframe> tag.

See more on https://sonarcloud.io/project/issues?id=jumpserver_luna&issues=AZ_QqcoPHqrTAqYRdKEF&open=AZ_QqcoPHqrTAqYRdKEF&pullRequest=1564

Check failure on line 104 in src/app/services/connect-token/batch-acl-dialog/batch-acl-dialog.component.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=jumpserver_luna&issues=AZ_Qqcr2HqrTAqYRdKEH&open=AZ_Qqcr2HqrTAqYRdKEH&pullRequest=1564

Check warning on line 395 in src/app/services/connect-token/batch-acl-dialog/batch-acl-dialog.component.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read.

See more on https://sonarcloud.io/project/issues?id=jumpserver_luna&issues=AZ_Qqcr2HqrTAqYRdKEM&open=AZ_Qqcr2HqrTAqYRdKEM&pullRequest=1564

Check warning on line 116 in src/app/services/connect-token/batch-acl-dialog/batch-acl-dialog.component.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read.

See more on https://sonarcloud.io/project/issues?id=jumpserver_luna&issues=AZ_Qqcr2HqrTAqYRdKEJ&open=AZ_Qqcr2HqrTAqYRdKEJ&pullRequest=1564