Repository navigation
fix(asset-tree): show address in favorite tooltip - #1640
Merged
Merged
Conversation
|
2 of 9 tasks
There was a problem hiding this comment.
🟡 Changes recommended
The new tooltip title can be undefined when an asset lacks meta.data.address, which can result in an empty/“undefined” tooltip and should be handled with a fallback.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Favorites asset tree node data so the zTree tooltip (node title) shows the asset’s address, improving usability when hovering favorite assets.
Changes:
- Add
title: info.meta?.data?.addressto favorite asset leaf nodes so tooltips show address information.
File summaries
| File | Description |
|---|---|
| src/app/elements/asset-tree/asset-tree.component.ts | Sets favorite asset leaf node title to the asset address to surface it in the tooltip. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| id: this.buildFavoriteLeafId(folderId || 'root', assetId), | ||
| pId: folderId ? 'folder-' + folderId : 'favorite-root', | ||
| name: info.name, | ||
| title: info.meta?.data?.address, |
| id: this.buildFavoriteLeafId(folderId || 'root', assetId), | ||
| pId: folderId ? 'folder-' + folderId : 'favorite-root', | ||
| name: info.name, | ||
| title: info.meta?.data?.address, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.