Skip to content

fix(chen): preserve pending edits during save preview #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zxc4wonder merged 2 commits into from
Sep 14, 2026
Merged

fix(chen): preserve pending edits during save preview #1664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8ed4d5
fix(chen): preserve pending edits during save preview
Zxc4wonder Sep 14, 2026
8091148
chore(chen): remove save preview test
Zxc4wonder Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ui/chen/components/DataGrid.client.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@ const rowData = computed(() => {
const dirtyVersion = props.editState?.dirtyVersion;
void dirtyVersion;
if (!props.dataset) return [];
if (props.editMode === "none" || !props.editState) return props.dataset.data;
return chenDataViewRows(props.dataset, props.editState);
});

Expand Down
3 changes: 2 additions & 1 deletion ui/chen/utils/dataViewEditing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,8 @@ export function isChenDirtyCell(
return Boolean(state.dirtyCells[dirtyKey(identity.key, field.sourceColumn)]);
}

export function chenDataViewRows(dataset: ChenDataViewDataset, state: ChenDataViewEditState) {
export function chenDataViewRows(dataset: ChenDataViewDataset, state: ChenDataViewEditState | null | undefined) {
if (!state) return dataset.data;
const rows = dataset.data.map((source) => {
const row = { ...source };
for (const field of dataset.fields) {
Expand Down
Loading