Repository navigation
Pr@dev@codex/fix windows workspace header drag - #1688
Merged
Merged
Conversation
|
There was a problem hiding this comment.
🔵 Needs a closer look
Port 8888 forwarding conflicts with the development gateway’s published local port.
Pull request overview
Updates Windows desktop header behavior by disabling workspace dragging and moving guest profile controls into the native title bar.
Changes:
- Add platform-aware header dragging and title-bar controls.
- Update guest profile presentation.
- Add header tests and forward port 8888 in the SSH helper.
File summaries
| File | Summary |
|---|---|
ui/components/Workspace/topHeader.vue |
Restricts dragging on Windows. |
ui/components/SideBar/profile.vue |
Updates guest profile labeling and icon. |
ui/components/Header/header.vue |
Controls Windows title-bar profile placement. |
ui/components/Header/header.test.ts |
Adds header visibility tests. |
ui/components/Header/DesktopTitleBar.vue |
Adds trailing slot support. |
scripts/ssh-port-forward.ps1 |
Adds port 8888 forwarding. |
Review details
Suppressed comments (1)
scripts/ssh-port-forward.ps1:4
- Adding
8888creates a local SSH listener on the same default port thatdocker-compose.yml:7publishes for the development gateway (127.0.0.1:${JMS_DEV_PORT:-8888}). When the standard stack and this helper are run together, one bind fails; withExitOnForwardFailure=yes, the forwarding process exits. Keep the local port configurable/use a different local port, or omit this port from the same-port forwarding list.
$ports = 5001, 5050, 8080, 2222, 8082, 3306, 5432, 8888
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Zxc4wonder
approved these changes
Sep 18, 2026
w940853815
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.