Repository navigation
fix(sftp): keep the panel file manager bound to its asset - #1734
Merged
Merged
Conversation
The cached SFTP surface was keyed by the SSH session id, so any transient session-detail refresh made the entry look like a different pane. The surface unmounted, its websocket dropped, and an in-flight transfer failed with an unavailable endpoint. Key the cache by pane, asset, and account instead. The koko session id now only gates creating a surface, never keeping one, so the file manager survives collapsing the sidebar, switching the right-panel tab, and session-detail churn. A surface is still rebuilt when the pane closes or the asset/account actually changes.
ZhaoJiSen
approved these changes
Sep 23, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(sftp): keep the panel file manager bound to its asset The cached SFTP surface was keyed by the SSH session id, so any transient session-detail refresh made the entry look like a different pane. The surface unmounted, its websocket dropped, and an in-flight transfer failed with an unavailable endpoint. Key the cache by pane, asset, and account instead. The koko session id now only gates creating a surface, never keeping one, so the file manager survives collapsing the sidebar, switching the right-panel tab, and session-detail churn. A surface is still rebuilt when the pane closes or the asset/account actually changes.