Skip to content

[fzf#vim#with_preview] Escape preview script path#558

Merged
junegunn merged 1 commit into
junegunn:masterfrom
janlazo:win_escape_previewpath
Jan 2, 2018
Merged

[fzf#vim#with_preview] Escape preview script path#558
junegunn merged 1 commit into
junegunn:masterfrom
janlazo:win_escape_previewpath

Conversation

@janlazo

@janlazo janlazo commented Jan 2, 2018

Copy link
Copy Markdown
Contributor

Related: #493
Close: #554

@junegunn junegunn merged commit 9036680 into junegunn:master Jan 2, 2018
@junegunn

junegunn commented Jan 2, 2018

Copy link
Copy Markdown
Owner

Thanks. Though unrelated, I just noticed that we can also remove (window =~ 'up\|down' ? '-v' : '') as fzf now exports $FZF_PREVIEW_HEIGHT to the preview process (as well as $LINES and $COLUMNS)

fzf --preview 'echo $FZF_PREVIEW_HEIGHT $LINES $COLUMNS'

@janlazo

janlazo commented Jan 2, 2018

Copy link
Copy Markdown
Contributor Author

0.16.7 mentions FZF_PREVIEW_WINDOW but FZF_PREVIEW_HEIGHT is available since 0.16.7 junegunn/fzf@eba9e04.

dunstontc added a commit to dunstontc/fzf.vim that referenced this pull request Mar 15, 2018
* 'master' of https://github.com/junegunn/fzf.vim:
  Update GGrep example to work at project level. (junegunn#590)
  [Helptags] Ignore wildignore setting (junegunn#567)
  Clarify that "fzf.vim" depends on "fzf"
  Remove deprecated function
  [fzf#vim#with_preview] workaround system() newline (junegunn#557)
  [fzf#vim#with_preview] Remove unnecessary -v flag
  [fzf#vim#with_preview] Escape preview script path (junegunn#558)
  [Tags] run perl for s:bin.tags (junegunn#559)
  Use $LINES instead of $FZF_PREVIEW_HEIGHT
  Decorate Vim 8 statusline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants