Simple maintenance improvements to shell scripts #2598
+66
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junegunn
reviewed
Mar 30, 2022
a1346054
changed the title
Contributor
Author
|
I rebased the pull request on latest master to fix merge conflicts, and reworked the commits to make the changes less intrusive, avoiding stylistic fixes. It makes the scripts more robust, and tiny bit faster because bash doesn't have to start up the globbing logic when variables are properly quoted. |
Contributor
Author
|
Rebased to fix merge conflicts. By the way, many of the underquoting issues could be fixed instead by using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.