Skip to content

Restore compatibility with GraalVM 25 - #5901

Open
marcphilipp wants to merge 6 commits into
mainfrom
marc/graalvm-25
Open

Restore compatibility with GraalVM 25#5901
marcphilipp wants to merge 6 commits into
mainfrom
marc/graalvm-25

Conversation

@marcphilipp

@marcphilipp marcphilipp commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Add test coverage for GraalVM 25
  • Log test events and output when using --info
  • Add serialization-config.json for compatibility with GraalVM 25

Fixes #5892.

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

@marcphilipp marcphilipp self-assigned this Jul 23, 2026
@marcphilipp marcphilipp changed the title Add serialization-config.json for compatibility with GraalVM 25 Restore compatibility with GraalVM 25 Jul 23, 2026
@marcphilipp
marcphilipp marked this pull request as draft July 23, 2026 14:25
@marcphilipp
marcphilipp marked this pull request as ready for review July 23, 2026 14:30
mpkorstanje
mpkorstanje reviewed Jul 23, 2026
View reviewed changes
Comment thread ...ces/META-INF/native-image/org.junit.platform/junit-platform-engine/serialization-config.json Outdated
@@ -0,0 +1,5 @@
[
{
"name": "org.junit.platform.engine.UniqueId$SerializedForm"

@mpkorstanje mpkorstanje Jul 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really fragile. Is there a way to generate it?

@marcphilipp marcphilipp Jul 23, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tracing agent does that for actual Graal applications. Maybe we can attach that to the test and at least verify it produces the same file?

@marcphilipp marcphilipp Jul 23, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbrannen @vjovanov Could one of you please chime in here?

@marcphilipp marcphilipp Jul 24, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created an issue asking for feedback:

@marcphilipp marcphilipp Jul 24, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've switched to the newer reachability-metadata.json now and added a test that uses the tracing agent and verifies that the serializable classes in the shipped file are identical to those generated by the agent for regular (non-native-image) test execution.

mpkorstanje
mpkorstanje reviewed Jul 23, 2026
View reviewed changes
Comment thread platform-tooling-support-tests/projects/graalvm-starter/build.gradle.kts
@marcphilipp marcphilipp mentioned this pull request Jul 24, 2026
Open
@testlens-app

testlens-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: 4754d4d
▶️ Tests: 34070 executed
⚪️ Checks: 17/17 completed

Learn more about TestLens at testlens.app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpkorstanje mpkorstanje mpkorstanje left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@marcphilipp marcphilipp

Labels

3rd-party: GraalVM component: Platform type: regression

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Native build failure since JUnit 6.1.0

2 participants

@marcphilipp @mpkorstanje