Prevent TemporaryFolder paths from escaping the root#1795
Closed
Q1Xuan wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TemporaryFolder promises to create named files and folders under its temporary root. The existing implementation rejected absolute folder paths, but parent traversal such as
..could still create files or folders outside the root.This change validates canonical paths before creating named files or folders, so traversal paths are rejected before anything is created.
Tests:
org.junit.rules.TemporaryFolderUsageTestwithJUnitCore(26 tests)git diff --checkI could not run
./mvnw.cmd -Dtest=org.junit.rules.TemporaryFolderUsageTest testlocally because Maven Wrapper was unable to download/start Maven in this environment.