Skip to content

Relax Kotlin contracts for Executable parameters #4481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: marc/jdk17
Choose a base branch
from
Draft

Relax Kotlin contracts for Executable parameters #4481

wants to merge 2 commits into from

Conversation

marcphilipp
Copy link
Member

  • Relax Kotlin contracts for Executable parameters
  • Treat Kotlin compiler warnings as errors again

Overview

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

@marcphilipp
Relax Kotlin contracts for Executable parameters
4c3297c 
Since `Executable` is allowed/expected to throw exceptions, the
semantics of being called `EXACTLY_ONCE` are blurry because it might not
be executed entirely when throwing an exception. Since the Kotlin 2.1
compiler emits a warning for these parameters, we're relaxing their
contracts to be called `AT_MOST_ONCE` instead.
@marcphilipp
Treat Kotlin compiler warnings as errors again
79993fe 
Now that #4371 is resolved.
@marcphilipp marcphilipp self-assigned this Apr 14, 2025
@marcphilipp marcphilipp linked an issue Apr 14, 2025 that may be closed by this pull request
Investigate Kotlin 2.1 compiler warnings for contracts #4371
Open
1 task
@marcphilipp marcphilipp mentioned this pull request Apr 14, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcphilipp marcphilipp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate Kotlin 2.1 compiler warnings for contracts
1 participant
@marcphilipp