Skip to content

Conversation

@junkurihara
Copy link
Owner

Deps and security patches

@junkurihara junkurihara requested a review from Copilot September 12, 2025 06:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the codebase to version 0.3.2 with dependency updates and security patches. The changes include upgrading the Rust edition to 2024, updating various dependencies to their latest versions, and making necessary code adjustments to work with the updated dependencies.

  • Updated Rust edition from 2021 to 2024
  • Upgraded multiple dependencies including tokio, opentelemetry, rand, and others
  • Modified code to use updated API methods from the new dependency versions

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Cargo.toml Version bump to 0.3.2 and Rust edition upgrade to 2024
modoh-lib/Cargo.toml Dependency version updates across multiple packages
modoh-bin/Cargo.toml Binary-specific dependency updates
httpsig-wire-proto/Cargo.toml Protocol library dependency updates
httpsig-registry/Cargo.toml Registry library dependency updates
modoh-lib/src/target/odoh.rs Updated rand API usage from thread_rng to rng
modoh-lib/src/request_filter/ip_filter.rs Import ordering and method name updates
modoh-lib/src/httpsig_handler/*.rs Variable name changes and import reordering
modoh-bin/src/*.rs OpenTelemetry API updates and import reordering
httpsig-wire-proto/src/*.rs Updated rand API usage in test code
Comments suppressed due to low confidence (1)

modoh-bin/src/trace.rs:1

  • The tracer provider is created twice on lines 242 and 244, but only the second instance is used for shutdown. This creates an unnecessary provider and doesn't properly shut down the one that was set globally. Remove the duplicate creation and use the same instance for both setting and shutdown.
use std::str::FromStr;

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@junkurihara junkurihara merged commit c1b928f into main Sep 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants