Add support for other pytorch device types, including MPS#1445
Open
adamobeng wants to merge 1 commit intojunyanz:masterfrom
Open
Add support for other pytorch device types, including MPS#1445adamobeng wants to merge 1 commit intojunyanz:masterfrom
adamobeng wants to merge 1 commit intojunyanz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes (#1441)
Change list
--device_typeand--device_idswhich allow torch backend and device ordinals to be specified--gpu_idsargument with some special logic (it would be cleaner but non-backwards compatible to remove it)Testing
python train.py --dataroot ./datasets/maps --name maps --model pix2pix --direction AtoB --device_type mpsseem reasonable.NB: On my specific setup, loading a model trained with MPS fails with
RuntimeError: don't know how to restore data location of torch.storage._UntypedStorage (tagged with mps:0), but it seems like this is a known and intermittent issue.