Skip to content

Fix DDP normalization type check logic #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mr-Neutr0n wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix DDP normalization type check logic #1715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions models/base_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,9 @@ def setup(self, opt):

# Wrap networks with DDP after loading
if dist.is_initialized():
# Check if using syncbatch normalization for DDP
if self.opt.norm == "syncbatch":
raise ValueError(f"For distributed training, opt.norm must be 'syncbatch' or 'inst', but got '{self.opt.norm}'. " "Please set --norm syncbatch for multi-GPU training.")
# Check if using syncbatch or instance normalization for DDP
if self.opt.norm != "syncbatch" and self.opt.norm != "instance":
raise ValueError(f"For distributed training, opt.norm must be 'syncbatch' or 'instance', but got '{self.opt.norm}'. " "Please set --norm syncbatch for multi-GPU training.")

net = torch.nn.parallel.DistributedDataParallel(net, device_ids=[self.device.index])
# Sync all processes after DDP wrapping
Expand Down