Skip to content

Update 6-faq.md #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update 6-faq.md #610

wants to merge 1 commit into from

Conversation

kitty4D
Copy link

@kitty4D kitty4D commented Mar 2, 2025

Primary reason for update

  • Added note to explicitly state that the swap (most likely by default) does now have a fee and that more information on changes associated with that are coming to the page. It's my understanding that this page will be updated as part of a more comprehensive update - but, in the meantime, I thought the page (now) erroneously saying there are absolutely no swap fees could be addressed with a quick note.

Additional updates

  • Cleaned up language where it seemed necessary/appropriate in the rest of the page.

Notes

  • I tried to make as few changes as possible when addressing issues that I felt existed with any language used. I did not address every issue that I saw, but, I would have felt weird submitting the PR if I didn't make a decent attempt at dealing with the majority of issues I saw.
  • Specific items:
    • The question on Limit Order about if the user is paying those txn fees - it's not answering it really. Txns the keeper signs, has fees paid by the keeper. But I think the question is wanting to know that the keeper is not taking the funds to pay this fee from what the user deposited. The answer given does not expicitly say this isn't the case.
    • The fee question on DCA has what feels like an incomplete answer. The fees that are withheld and then claimable anytime, presumably this is only applicable when we're talking about a partner integration. Limit Order has a specific note about partner integrations / referral fees. For DCA, nothing is included about that. My assumption is, either info about partners is missing, or the "claimable anytime" sentence should be removed.
    • I may have used too many exclamation points in the "Can I contribute" section but I'll leave that up to you to decide. Just noting it to help.
    • On the section about "unable to fetch balance changes" - here I actually break from what was previously stated. Before it had a note saying that there is nothing to worry about when using a dApp previously used and trusted. I disagree strongly with that, and feel it is dangerous to say it in such a generalized way. I believe the changes I made here are the only actual substantive changes.

No worries if you ignore / don't use any of this.

Added a note to explicitly state that the swap (most likely by default) does now have a fee and that more information on changes associated with that are coming to the page.

Cleaned up language where it seemed necessary/appropriate in the rest of the page.
Copy link

vercel bot commented Mar 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
jupiter-space-station ✅ Ready (Inspect) Visit Preview Mar 2, 2025 6:49am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant