Skip to content

build(cmake): fix generator expression #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/bazel-ci.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
name: Bazel CI
on: [pull_request]
on:
pull_request:
push:
branches:
- master

jobs:
build:
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/cmake-ci.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
name: CMake CI
on: [pull_request]
on:
pull_request:
push:
branches:
- master

jobs:
build:
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
name: Coverage
on: [pull_request]
on:
pull_request:
push:
branches:
- master

jobs:
build:
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/linting.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
name: Linting
on: [pull_request]
on:
pull_request:
push:
branches:
- master

jobs:
iwyu:
Expand Down
2 changes: 1 addition & 1 deletion core/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ target_compile_features(core
target_link_libraries(core
PRIVATE
Threads::Threads
$<$<AND:$<BOOL:UNIX>,$<NOT:$<BOOL:APPLE>>>:rt>
$<$<AND:$<BOOL:${UNIX}>,$<NOT:$<BOOL:${APPLE}>>>:rt>
)

if(HAVE_CXX_LIBATOMIC)
Expand Down
2 changes: 1 addition & 1 deletion pull/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ target_link_libraries(pull
${PROJECT_NAME}::util
Threads::Threads
$<IF:$<BOOL:${USE_THIRDPARTY_LIBRARIES}>,${PROJECT_NAME}::civetweb,civetweb::civetweb-cpp>
$<$<AND:$<BOOL:UNIX>,$<NOT:$<BOOL:APPLE>>>:rt>
$<$<AND:$<BOOL:${UNIX}>,$<NOT:$<BOOL:${APPLE}>>>:rt>
$<$<BOOL:${ENABLE_COMPRESSION}>:ZLIB::ZLIB>
)

Expand Down
2 changes: 1 addition & 1 deletion push/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ target_link_libraries(push
PRIVATE
${PROJECT_NAME}::util
Threads::Threads
$<$<AND:$<BOOL:UNIX>,$<NOT:$<BOOL:APPLE>>>:rt>
$<$<AND:$<BOOL:${UNIX}>,$<NOT:$<BOOL:${APPLE}>>>:rt>
)

target_include_directories(push
Expand Down
Loading