Getting chunks from Codemirror.#43
Open
nakul-py wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Triggering CI |
Collaborator
|
This seems to add more complexity. |
Contributor
Author
|
That's a fair point. Since accept/reject applies to the whole document, we don’t strictly need chunk-level operations. However, I agree that if we only support full-document accept/reject here, the simpler approach may be preferable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using chunks provided by Codemirror acceptChunk, rejectChunk instead of handling them manually.