Skip to content

Getting chunks from Codemirror.#43

Open
nakul-py wants to merge 2 commits into
jupyter-ai-contrib:mainfrom
nakul-py:refactor
Open

Getting chunks from Codemirror.#43
nakul-py wants to merge 2 commits into
jupyter-ai-contrib:mainfrom
nakul-py:refactor

Conversation

@nakul-py

@nakul-py nakul-py commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Using chunks provided by Codemirror acceptChunk, rejectChunk instead of handling them manually.

@nakul-py

nakul-py commented Feb 5, 2026

Copy link
Copy Markdown
Contributor Author

Triggering CI

@nakul-py nakul-py closed this Feb 5, 2026
@nakul-py nakul-py reopened this Feb 5, 2026
@brichet

brichet commented Feb 23, 2026

Copy link
Copy Markdown
Collaborator

This seems to add more complexity.
I wonder if there is an advantage of accepting/rejecting chunks one by one when we want to update the whole file.

@nakul-py

Copy link
Copy Markdown
Contributor Author

That's a fair point. Since accept/reject applies to the whole document, we don’t strictly need chunk-level operations.
The reason I used chunks here just was to align with the CodeMirror merge extension.

However, I agree that if we only support full-document accept/reject here, the simpler approach may be preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants