⚠️ DO NOT MERGE ⚠️ — 🤖 Store execution outputs in Outputs
#1903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 56d0d49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agoose77
force-pushed
the
agoose77/feat-future-ast-outputs
branch
3 times, most recently
from
cec055e to
6870f57
Compare
rowanc1
reviewed
Mar 7, 2025
|
Thoughts on a testing plan for this:
|
agoose77
commented
Mar 7, 2025
agoose77
commented
Mar 7, 2025
agoose77
commented
Mar 7, 2025
rowanc1
reviewed
Mar 7, 2025
rowanc1
reviewed
Mar 7, 2025
| const outputsNode = select('outputs', block) as GenericNode | undefined; | ||
| if (outputsNode !== undefined && !outputsNode.identifier) { | ||
| // Label outputs node | ||
| outputsNode.identifier = `${block.identifier}-output`; |
There was a problem hiding this comment.
I think that these ID changes may need to be taken into account in the upgrade/downgrade script for thebe to continue working.
There was a problem hiding this comment.
Let's keep an eye on that
agoose77
force-pushed
the
agoose77/feat-future-ast-outputs
branch
2 times, most recently
from
d8a8684 to
6f0d05b
Compare
agoose77
commented
Apr 1, 2025
| @@ -270,12 +273,14 @@ describe('propagateBlockDataToCode', () => { | |||
| result = mdast.children[0].children[0].visibility; | |||
| break; | |||
| case 'output': | |||
| if (!has_output && target == 'output') { | |||
There was a problem hiding this comment.
target is known to be output here.
agoose77
force-pushed
the
agoose77/feat-future-ast-outputs
branch
from
2060521 to
5857844
Compare
We don't need to delete nodes without children: they will simply vanish when lifted
Closed
3 tasks
agoose77
changed the title
OutputsOutputs
agoose77
force-pushed
the
agoose77/feat-future-ast-outputs
branch
from
826b957 to
455e0d8
Compare
agoose77
changed the title
OutputsOutputs
agoose77
changed the title
OutputsOutputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes our internal representation of cell outputs so that they are children of the
Outputsnode.It accompanies #1900, and closes #1674
Notable Changes
outputs-${N}outputsnode with identifier${block.identifier}-outputsOutputsparent nodeTasks
.docxexports still export matplotlib figuresJATSexports still export matplotlib figures