feat(tex): support page parameter for includegraphics with multi-page pdf #1922
Conversation
🦋 Changeset detectedLatest commit: 56921a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Nice, looks great. Left a few minor things.
Could you also add page with a comment here:
https://github.com/executablebooks/mystmd/blob/main/packages/myst-spec-ext/src/types.ts#L117
e.g.
export type Image = SpecImage & {
urlSource?: string;
urlOptimized?: string;
height?: string;
placeholder?: boolean;
/** Optional page number for PDF images, this ensure the correct page is extracted when converting to web and translated to LaTeX */
page?: number;
};
| options?.trim ? ' -trim' : '' | ||
| } ${output}`; | ||
| session.log.debug(`Executing: ${executable}`); | ||
|
|
||
| session.log.info(`Executing: ${executable}`); |
There was a problem hiding this comment.
| session.log.info(`Executing: ${executable}`); | |
| session.log.debug(`Executing: ${executable}`); |
packages/tex-to-myst/src/figures.ts
Outdated
| @@ -1,7 +1,8 @@ | |||
| import type { GenericNode } from 'myst-common'; | |||
| import { u } from 'unist-builder'; | |||
| import type { Handler, ITexParser } from './types.js'; | |||
| import { getArguments, texToText } from './utils.js'; | |||
| import { getArguments, extractParams, texToText } from './utils.js'; | |||
| import { group } from 'console'; | |||
packages/tex-to-myst/src/figures.ts
Outdated
| } | ||
| if (params.page) { | ||
| if (typeof params.page === 'number') { | ||
| params.page = Number(params.page) - 1; // Convert to 0-based for imagemagick |
There was a problem hiding this comment.
Do we need to round or parse this or have something similar to Number.isFinite(Number.parseFloat(params.page))?
There was a problem hiding this comment.
You're right! Unless I'm mistaken, I think the extractParams should already have done the parsing, but I've added the missing Number.isFinite and the rounding.
Add support for selecting specific pages in multi-page PDFs
In LaTeX, when including a multi-page PDF as a graphic, it's possible to specify a page number:
However, the page parameter is currently ignored, causing all the links to point only to the first page, even though ImageMagick extracts and converts all pages.
This PR adds support for the page parameter, ensuring that the correct page is selected when converting multi-page PDFs.