Cannot load plugins without proj config #1925
Conversation
`loadPlugins` sometimes get invoked before the project config is
available. In that case, it will not load the plugins, but when the
next chance comes to do so, it will take the early exit ("we already
tried to load plugins") instead of loading them.
stefanv
force-pushed
the
cannot-load-plugins-without-projConfig
branch
from
f45415a to
1b15b15
Compare
|
|
@stefanv can you share the thought process behind why this PR is necessary? From a first glance, it means that |
|
Yes, I believe there is a bug currently. When I start the myst content server, I noted that plugins are not loaded. This PR avoids the problematic usage of loadPlugins where the project config is not yet available. All subsequent attempts to load plugins then fails. This at least makes plugins work with web page content, but it does not address another issue, which is that parts are loaded even earlier, before plugins are available. |
|
Can you publish a reproducer? The myst docs use plugins, and the content server loads them just fine. |
|
I added the scienceicons extension to the landing-pages repo. I can share the exact repo, and log, showing that the plugin doesn't load, when I'm back at a computer. |
|
Hi @stefanv, any update on a reproducer here? |
|
Looks like an interaction between using parts + plugin. Try this content repo: https://github.com/stefanv/cryocloud-landing-demo/tree/no-plugin-reproducer And then use this PR branch vs main branch of mystmd. You'll (hopefully) see that the plugins load with one, but not the other. |
No description provided.