Skip to content

Document the launch button functionality #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2025
Merged

Document the launch button functionality #2046

merged 4 commits into from
May 22, 2025

Conversation

choldgraf
Copy link
Collaborator

@choldgraf choldgraf commented May 21, 2025

This documents the launch button functionality that has been in the myst-theme for a while now. It looks like we never got around to putting it in the actual user documentation.

Preview: https://deploy-preview-2046--mystmd.netlify.app/website-launch-buttons

Copy link

changeset-bot bot commented May 21, 2025

⚠️ No Changeset found

Latest commit: cdcc555

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@choldgraf choldgraf added the documentation Improvements or additions to documentation label May 21, 2025
choldgraf and others added 2 commits May 21, 2025 12:03
Copy link
Contributor

@agoose77 agoose77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! In future, we could likely drop the need for jupyter: true. I think the only issue to be mindful of is to avoid adding the button where people don't want it -- i.e. if opt-out is sufficient.

@agoose77 agoose77 merged commit fa1016d into main May 22, 2025
5 checks passed
@agoose77 agoose77 deleted the launch-buttons branch May 22, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants