-
Notifications
You must be signed in to change notification settings - Fork 128
Add a description of the theme server contract #2566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Some things that aren't clear:
|
Co-authored-by: Angus Hollands <[email protected]>
|
The CI failure seems unrelated and just general flakiness. |
|
|
||
| ## Architecture in brief | ||
|
|
||
| The MyST engine runs the content pipeline, while the theme is a web server that renders that content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In future we should link to or author a section that describes this separation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean? I'm not sure what is missing.
This documents the contract between the engine and the theme server, and I was motivated to add it because it helps me understand the discussion in jupyter-book/myst-enhancement-proposals#34
AI disclosure
Most of the text is implemented using OpenAI codex, which I subsequently reviewed checking for completeness and overall soundness. I did not validate against the source code because my limited typescript knowledge and the need to search through the codebase make it a challenge.