Skip to content

Fix support for IPython 8 and 9#959

Merged
devstein merged 2 commits intojupyter-incubator:masterfrom
ddrinka:patch-1
May 28, 2025
Merged

Fix support for IPython 8 and 9#959
devstein merged 2 commits intojupyter-incubator:masterfrom
ddrinka:patch-1

Conversation

@ddrinka
Copy link
Contributor

@ddrinka ddrinka commented May 27, 2025

Description

A public API for IPython.display was introduced in ipython==4.1.2. Access to the tool via the internal API was deprecated in 7.14, warned against through 8.*, and removed in 9.0.

With this change, hdijupyterutils targets the public API which enables support for the most recent versions of IPython, but requires a minor version change for the minimum required version.

Closes #957

`IPython.core.display.display` was removed in IPython 8.0.0.  Update the reference to support modern IPython versions.

Closes jupyter-incubator#957
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. kind:bug An unexpected error or issue with sparkmagic labels May 27, 2025
Copy link
Collaborator

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing @ddrinka! Do you know what version of ipython introduced IPython.display over IPython.core? I'm wondering if we need to bump the min ipython requirement

@ddrinka
Copy link
Contributor Author

ddrinka commented May 27, 2025

@devstein Looks like release 4.1.2

The public API for display tools in IPython was added in release 4.1.2.  Rather than depending on the now-deprecated internal location of those tools, we'll advance the minimum IPython by a minor version.
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels May 27, 2025
@ddrinka
Copy link
Contributor Author

ddrinka commented May 27, 2025

I've adjusted the required IPython version and added a Changelog entry since this now introduces an external-facing change.

@ddrinka ddrinka changed the title Remove reference to deprecated display call Fix support for IPython 8 and 9 May 27, 2025
@devstein
Copy link
Collaborator

Perfect - thank you @ddrinka! I can do a release after merging

@devstein devstein merged commit aedbd47 into jupyter-incubator:master May 28, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug An unexpected error or issue with sparkmagic size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] IPython.core.display import issue

2 participants