-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stroke path to Path2D interface per html canvas spec #350
Add stroke path to Path2D interface per html canvas spec #350
Conversation
Looks great!
This could be as simple as adding a new cell at the end of this Notebook testing the feature: |
CI failures look unrelated, I will fix them in parallel |
* add stroke(path: Path2D) form to canvas --------- Co-authored-by: Chris Lee-Messer <[email protected]>
Done and rebased. There is a linting failure that comes from this PR. |
|
Thanks!
|
bot please update snapshots |
I went ahead and ran black again on canvas.py and pushed the commit. ..oops my push failed at first because I had not resynced with upstream. now should be available |
Thanks!
I don't see your new commit, are you sure you pushed?
Sounds good! |
bot please update snapshots |
Triggering CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
current deficiencies I am aware off:
lackstestslacksdocumentation