Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move notebook conf.d file to use python package name, which will not have a slash in it #80

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ jobs:

- name: Run pip install
shell: bash -l {0}
run: pip install ./jupyter-widget-testwidgets
run: python -m pip install ./jupyter-widget-testwidgets

- name: Test install
shell: bash -l {0}
run: |
test -d $CONDA_PREFIX/share/jupyter/nbextensions/jupyter-widget-testwidgets
test -f $CONDA_PREFIX/etc/jupyter/nbconfig/notebook.d/jupyter-widget-testwidgets.json
test -d $CONDA_PREFIX/share/jupyter/labextensions/jupyter-widget-testwidgets
test -f $CONDA_PREFIX/share/jupyter/labextensions/jupyter-widget-testwidgets/package.json
test -d $CONDA_PREFIX/share/jupyter/nbextensions/@jupyter-widgets/jupyter-widget-testwidgets
test -f $CONDA_PREFIX/etc/jupyter/nbconfig/notebook.d/jupyter_widget_example.json
test -d $CONDA_PREFIX/share/jupyter/labextensions/@jupyter-widgets/jupyter-widget-testwidgets
test -f $CONDA_PREFIX/share/jupyter/labextensions/@jupyter-widgets/jupyter-widget-testwidgets/package.json
2 changes: 1 addition & 1 deletion tests/testconfig.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ default_context:
author_email: "[email protected]"
github_project_name: "jupyter-widget-testwidgets"
github_organization_name: "jupyter"
npm_package_name: "jupyter-widget-testwidgets"
npm_package_name: "@jupyter-widgets/jupyter-widget-testwidgets"
npm_package_version: "1.1.0"
project_short_description: "A Test Jupyter Widget Library"
2 changes: 1 addition & 1 deletion {{cookiecutter.github_project_name}}/MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ graft js
graft tests
prune **/node_modules

include {{ cookiecutter.npm_package_name }}.json
include {{ cookiecutter.python_package_name }}.json

include LICENSE
include setup.py
Expand Down
2 changes: 1 addition & 1 deletion {{cookiecutter.github_project_name}}/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
('share/jupyter/nbextensions/{{ cookiecutter.npm_package_name }}', '{{ cookiecutter.python_package_name }}/nbextension', '*.*'),
('share/jupyter/labextensions/{{ cookiecutter.npm_package_name }}', '{{ cookiecutter.python_package_name }}/labextension', "**"),
("share/jupyter/labextensions/{{ cookiecutter.npm_package_name }}", '.', "install.json"),
('etc/jupyter/nbconfig/notebook.d', '.', '{{ cookiecutter.npm_package_name }}.json'),
('etc/jupyter/nbconfig/notebook.d', '.', '{{ cookiecutter.python_package_name }}.json'),
]

cmdclass = create_cmdclass('jsdeps', data_files_spec=data_files_spec)
Expand Down