Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ability to specify registry when using docker images #2008

Merged

Conversation

mathbunnyru
Copy link
Member

Describe your changes

Work on: jupyterhub/team-compass#688

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

This doesn't change the registry to quay yet, but rather gives an ability to specify the registry.
I would like to merge this change separately - if we ever decide to change registry again, it will be simple.
After merging this, changing registry should only require only a few lines of code change.

@mathbunnyru mathbunnyru force-pushed the asalikhov/add_registry_customization branch from 2a8ef1e to 47020ff Compare October 19, 2023 18:42
@mathbunnyru mathbunnyru force-pushed the asalikhov/add_registry_customization branch from 47020ff to 3af0055 Compare October 19, 2023 19:01
@mathbunnyru mathbunnyru merged commit f8cd90a into jupyter:main Oct 19, 2023
3 of 49 checks passed
@minrk
Copy link
Member

minrk commented Oct 20, 2023

Amazing, great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants