Robust registry operations: adjust timelimit and use retries #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbunnyru
commented
Mar 26, 2025
| @@ -18,7 +18,7 @@ on: | |||
| timeout-minutes: | |||
| description: Timeout in minutes | |||
| type: number | |||
| default: 25 | |||
There was a problem hiding this comment.
These timeouts were too big and almost always it should end in ~6 minutes.
With retry 10 should be enough.
mathbunnyru
commented
Mar 26, 2025
| --variant ${{ inputs.variant }} | ||
| --tags-dir /tmp/jupyter/tags/ | ||
| run: | | ||
| python3 -m tagging.apps.merge_tags \ |
There was a problem hiding this comment.
A bit of code duplication, but I don't think that's a huge deal
|
I'm a bit tired of rerunning workflows manually, so decided to add retries to workflows. |
|
Retries definitely help: https://github.com/jupyter/docker-stacks/actions/runs/14131791270/job/39597506278 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket if applicable
Checklist (especially for first-time contributors)