Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing JEPs, move kernel-subshells to follow convention #130

Merged
merged 10 commits into from
Mar 11, 2025

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Mar 5, 2025

Also fixes syntax error in Kernel Handshaking pattern link on the website and moves Notebook v7 to "Implemented' in ToC (it was marked as Implemented in README in my previous #124).

Before After
image image
Before After
image image

Changes in the table shading and search bar are due to newer version of sphinx/sphinx-book-theme.

@krassowski

This comment was marked as outdated.

@krassowski
Copy link
Member Author

I don't know if SSC at some point decided not to add numerical prefixes any more and not to update the website, but given that almost none of the JEPs accepted in last two years are discoverable via https://jupyter.org/enhancement-proposals/ which is the public facing index of JEPs, I think this was not a good idea.

@krassowski
Copy link
Member Author

krassowski commented Mar 6, 2025

Probably a number of JEPs which I added to ToC/READMEas "Accepted" are already implemented, but I think this PR is already large and I do not want to hold it for discussions on whether something is implemented or not (like subshells are partially implemented).

Also capitalization probably should be made consistent but I mostly kept it as-is just fixing the code syntax as needed.

@krassowski
Copy link
Member Author

CC @jupyter/software-steering-council please review.

@krassowski
Copy link
Member Author

Thanks for the approval! I do not have merge rights here, so someone from SSC or EC will need to do that.

@Zsailer
Copy link
Member

Zsailer commented Mar 11, 2025

Thanks @krassowski! And thank you @minrk for the review. Merging.

@Zsailer Zsailer merged commit 31ed6fa into jupyter:master Mar 11, 2025
2 checks passed
@krassowski krassowski deleted the fix-missing-jep branch March 11, 2025 18:10
@krassowski krassowski mentioned this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants