-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore usage of flake8 and add to CI #316
Conversation
Thank you @danyeaw! I was thinking that it might be helpful to have the pre-commit information in the To apply code formatting before committing changes, install pre-commit and the pre-commit git hooks. The hooks are defined in
I can merge this in and follow up on the documentation, or if you'd like to included here as well? Please let me know your thoughts! |
Hi @RRosio, thanks so much for the feedback! Clear contributor instructions are really important and this is a great idea to improve this PR. I updated the I was also getting a CI failure because v1 of check-release was using a really old version of actions/cache, so I bumped it to v2 as well. |
Thank you @danyeaw! |
In #315, I accidently removed the flake8 configuration that was in the setup.cfg. This PR restores it and makes some additional improvements:
It would also be great to eventually move to using Ruff like jupyter/notebook, but that would be a much larger cleanup effort.