New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offload npm scripts to a build.js #318

Closed

danyeaw wants to merge 3 commits into jupyter:main from danyeaw:build.js

Contributor

danyeaw commented Feb 11, 2025 •

edited

Loading

This PR simplifies the package.json to move some of the build logic to a new build.js file. Tradeoffs considered:

This increases the build system maintenance overhead
It simplifies the package.json to make it more manageable
It improves build performance to allow multiple build steps to happen in parallel (9.4s to 7.4s - 22% decrease)

This PR was originally part of #317, but I split it out to try to reduce the size of the PR and help troubleshoot CI build errors.

danyeaw added 3 commits

February 11, 2025 16:08


          Offload npm scripts to a build.js

95c074e


          Explicitly declare each build task

1c876b0


          Make cross-platform, and run in parallel

b2fb816

Contributor Author

danyeaw commented Feb 12, 2025

Although I got this working, I don't think maintaining the extra JavaScript is worth the small performance gain.

danyeaw closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet