Fixed issue with INLINE_MATH_TEX regex to accept spaces within inline#2188
Open
lokashrinav wants to merge 2 commits intojupyter:mainfrom
Open
Fixed issue with INLINE_MATH_TEX regex to accept spaces within inline#2188lokashrinav wants to merge 2 commits intojupyter:mainfrom
lokashrinav wants to merge 2 commits intojupyter:mainfrom
Conversation
… math expressions. Updated the INLINE_MATH_TEX regex pattern to allow spaces within the inline math expression. Ensured proper escaping of dollar signs and backslashes. This change addresses the issue with spaces that users encounter
for more information, see https://pre-commit.ci
Member
|
I think this makes sense but before merging we need a unit test here |
Author
|
@krassowski Hey krassowski, could i ask for some help on how to add unit tests here/understand what next to do? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the INLINE_MATH_TEX regex pattern to allow spaces within the inline math expression. Ensured proper escaping of dollar signs and backslashes. This change addresses the issue with spaces that users encounter.
This is a further fix for this issue from Jupyter Lab/Notebook since the original style may confuse the users with issues, such as in the following: jupyterlab/jupyterlab#11062
Transformed oriignal INLINE_MATH_TEX to INLINE_MATH_TEX = _dotall(r"(?<![$\])$(?!\s)(?P<math_inline_tex>[^$\\\s]+?)(?<!\s)(?<![$\])$")
Feel free to decide what you think should be done, and if further testing should be done.