Skip to content

fix: Allow null kernelspec in OverwriteKernelspec #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Allow null kernelspec in OverwriteKernelspec #1962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions nbgrader/preprocessors/overwritekernelspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@ def preprocess(self, nb: NotebookNode, resources: ResourcesDict) -> Tuple[Notebo
db_url = resources['nbgrader']['db_url']

with Gradebook(db_url) as gb:
kernelspec = json.loads(
gb.find_notebook(notebook_id, assignment_id).kernelspec)
kernelspec = gb.find_notebook(notebook_id, assignment_id).kernelspec
if kernelspec is not None:
kernelspec = json.loads(kernelspec)

self.log.debug("Source notebook kernelspec: {}".format(kernelspec))
self.log.debug(
"Submitted notebook kernelspec: {}"
Expand Down
19 changes: 19 additions & 0 deletions nbgrader/tests/preprocessors/test_overwritekernelspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,22 @@ def test_overwrite_kernelspec(self, preprocessors, resources, gradebook):
notebook = gradebook.find_notebook("test", "ps0")
assert nb.metadata['kernelspec'] == kernelspec
assert json.loads(notebook.kernelspec) == kernelspec

def test_overwrite_kernelspec_null_spec(self, preprocessors, resources, gradebook):
# Create a notebook without a kernelspec
gradebook.add_notebook("test", "ps0")

kernelspec = dict(
display_name="Python 3",
name="python3",
language="python",
)

nb = new_notebook()
nb.metadata["kernelspec"] = kernelspec
nb, resources = preprocessors[1].preprocess(nb, resources)

validate(nb)
notebook = gradebook.find_notebook("test", "ps0")
assert notebook.kernelspec is None
assert nb.metadata["kernelspec"] == kernelspec
Loading