Skip to content

Add binder's tolerations to image-cleaner and container-builder #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

paololazzari
Copy link
Contributor

Fixes #1962

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also missing from the builder daemonset:

tolerations:
- effect: NoSchedule
key: hub.jupyter.org/dedicated
operator: Equal
value: user
- effect: NoSchedule
key: hub.jupyter.org_dedicated
operator: Equal
value: user

@paololazzari paololazzari changed the title Add binder's tolerations to image-cleaner Add binder's tolerations to image-cleaner and container-builder May 15, 2025
@paololazzari
Copy link
Contributor Author

paololazzari commented May 15, 2025

It's also missing from the builder daemonset:

tolerations:
- effect: NoSchedule
key: hub.jupyter.org/dedicated
operator: Equal
value: user
- effect: NoSchedule
key: hub.jupyter.org_dedicated
operator: Equal
value: user

I added the change there too.

@consideRatio
Copy link
Member

Thank you @paololazzari!!

@consideRatio
Copy link
Member

A single toleration for all may or may not make sense, I am not sure. Is this the right config to peovide, or is it more suitable to provide tolerations under imagecleaner specific config etc?

Writing from mobile with little time, so have not looked into it myself

@manics
Copy link
Member

manics commented May 15, 2025

I think it's fine, if necessary we can add .Values.<component>.tolerations in future and have them override .Values.tolerations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose additional tolerations for image cleaner
3 participants