-
Notifications
You must be signed in to change notification settings - Fork 392
Add binder's tolerations to image-cleaner and container-builder #1963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also missing from the builder daemonset:
tolerations: | |
- effect: NoSchedule | |
key: hub.jupyter.org/dedicated | |
operator: Equal | |
value: user | |
- effect: NoSchedule | |
key: hub.jupyter.org_dedicated | |
operator: Equal | |
value: user |
I added the change there too. |
Thank you @paololazzari!! |
A single toleration for all may or may not make sense, I am not sure. Is this the right config to peovide, or is it more suitable to provide tolerations under imagecleaner specific config etc? Writing from mobile with little time, so have not looked into it myself |
I think it's fine, if necessary we can add |
Fixes #1962