Support both Unicode and Path for icon_path.#575
Open
ryanlovett wants to merge 2 commits intojupyterhub:mainfrom
Open
Support both Unicode and Path for icon_path.#575ryanlovett wants to merge 2 commits intojupyterhub:mainfrom
ryanlovett wants to merge 2 commits intojupyterhub:mainfrom
Conversation
manics
reviewed
Apr 21, 2026
|
|
||
| icon_path = Unicode( | ||
| "", | ||
| icon_path = Union( |
Member
There was a problem hiding this comment.
Does CUnicode work? It's meant to be a casting variant of Unicode so might automatically convert Path to string.
https://traitlets.readthedocs.io/en/stable/trait_types.html#traitlets.CUnicode
Member
There was a problem hiding this comment.
CUnicode is a little overly permissive because it will accept anything and cast to str. I think we should generally operate as if the C casting traitlets don't exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses jupyterhub/repo2docker#1520 (comment)