Add admin_groups to grant admin access to users of these groups#198
Open
Vendetta01 wants to merge 3 commits intojupyterhub:mainfrom
Open
Add admin_groups to grant admin access to users of these groups#198Vendetta01 wants to merge 3 commits intojupyterhub:mainfrom
Vendetta01 wants to merge 3 commits intojupyterhub:mainfrom
Conversation
Added tests and fixed admin flag not returned if user_info is not set.
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
When this PR will be merged? |
|
👍 for getting this merged! Thanks for the contribution |
|
plus for this PR. When it will be merged? |
consideRatio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new configuration option
admin_groups, to grant admin access to all users that are members of these groups and thus lets you define admin access through ldap group membership. Its implementation is similar toallowed_groups.This fixes #160.