Skip to content

Fix launcher icon rendering - #296

Open
MUFFANUJ wants to merge 2 commits into
jupyterlab:mainfrom
MUFFANUJ:fixSvgRendProb
Open

Fix launcher icon rendering#296
MUFFANUJ wants to merge 2 commits into
jupyterlab:mainfrom
MUFFANUJ:fixSvgRendProb

Conversation

@MUFFANUJ

Copy link
Copy Markdown
Member

Fixes #295

Replace generic gradient IDs in Python-logo-notext.svg with unique IDs and update url(#...) references to avoid collisions when the icon is rendered multiple times.

@krassowski

Copy link
Copy Markdown
Member

I think this is not enough. What I was suggesting was dropping defs altogether and embedding the definition in the group.

@MUFFANUJ
MUFFANUJ requested a review from krassowski April 27, 2026 20:57
@krassowski

Copy link
Copy Markdown
Member

I don't think this will help either. I was thinking that grouping with <g> could help, but it does not seem to work either. I think we would need to solve jupyterlab/jupyterlab#18826 upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

The launcher icon is randomly not rendered due to non-unique gradient ID

2 participants