Fix language indicator regex in magics #1307
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
dlqqq
requested changes
Apr 4, 2025
packages/jupyter-ai-magics/jupyter_ai_magics/tests/test_magics.py
Outdated
Show resolved
Hide resolved
dlqqq
added
bug
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Jiya873
commented
Apr 5, 2025
|
@Jiya873 The unit tests are not passing. Can you help reproduce the error locally using |
|
Thank you for the feedback. I’ll run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1236 by updating the lang_indicator regex in magics.py to correctly detect language specifiers in code blocks. The new pattern ensures that the language name appears immediately after the triple backticks, followed by a space and a newline. This prevents incorrect matches and improves compatibility with markdown syntax.