Enforce modern Python code using pre-commit running pyupgrade --py39-plus
#1329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add `autoflake` to remove unused imports after switching to PEP 585.
rominf
force-pushed
the
rominf-pyupgrade
branch
from
104fe16 to
0bc019e
Compare
rominf
changed the title
pre-commit, pyupgrade --py39-plus, and GitHub Actionspre-commit running pyupgrade --py39-plus
|
@rominf Wow, thank you for working on this! I had no idea that this was possible with our existing linter tools. This is awesome, and should slightly improve the server performance. It may take a while for this PR to get merged. It would be easiest to merge the other open PRs first to minimize the number of merge conflicts we need to fix manually. Thank you for your patience in the meantime! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1326.
Update
pyupgradeinpre-committo--py39-plusto enforce PEP 585. Also addautoflaketopre-committo remove unused imports after switching to PEP 585.An alternative solution would be replace most
pre-commitrules withruff(https://docs.astral.sh/ruff/), however I wanted to move gradually. I am open opening a PR with introducingruff.