-
-
Notifications
You must be signed in to change notification settings - Fork 472
Update Anthropic model list #1515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jemshid Thank you for contributing the updated model list for Anthropic! 🤗
Right now, Jupyter AI v2 is in maintenance mode. Our goal for JAI v2 right now is to preserve the stable experience that users expect & keep changes limited to bug fixes & patches. All feature development is occurring on the new main branch (JAI v3) and in the broader @jupyter-ai-contrib org.
Even though the changes to config_manager.py and chat_handlers/base.py look OK, they are feature additions specific to the Anthropic provider. These changes risk introducing a bug and don't provide value for non-Anthropic users. Can you simplify this PR by just updating the model list in anthropic.py, and revert all other changes? I'd be happy to merge this PR after.
BTW, CHANGELOG.md should not be manually updated; that file is automatically updated every release by our release scripts.
- Add Claude 4.5 models (Sonnet, Opus, Haiku) - Add Claude 4.1 and 4.0 models - Add Claude 3.7 Sonnet - Remove deprecated Claude 2.x models - Remove deprecated Claude 3.5 Sonnet (20240620) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
be3672d to
710c2bf
Compare
|
Thank you for the feedback! I've simplified the PR as requested. Changes made:
What remains:
The PR now contains just 1 file change with no feature additions - purely a model list update suitable for JAI v2 maintenance mode. Ready for your review! |
srdas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This a simple fix that looks good. We have taken a similar approach in the past.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Description
Updates the Anthropic provider's model list to include current Claude models and remove deprecated ones.
Changes
claude-2.0,claude-2.1)claude-3-5-sonnet-20240620)Files Changed
packages/jupyter-ai-magics/jupyter_ai_magics/partner_providers/anthropic.pyNotes