Remove setuptools dependency

[Darshan808]

Fixes #106

Description

Drop the use of setuptools and create custom implementation of find_packages and find_namespace_packages.

[Darshan808]

The only place we might use setuptools is in this script, which is a fallback for getting package name

jupyter-builder/jupyter_builder/federated_extensions.py

Lines 548 to 564 in 9b08563

	# Try getting the package name from setup.py
	if not package:
	try:
	package = (
	subprocess.check_output(
	[sys.executable, "setup.py", "--name"],
	cwd=mod_path,
	)
	.decode("utf8")
	.strip()
	)
	except subprocess.CalledProcessError:
	msg = (
	f"The Python package `{module}` is not a valid package, "
	"it is missing the `setup.py` file."
	)
	raise FileNotFoundError(msg) from None

[krassowski]

The only place we might use setuptools is in this script, which is a fallback for getting package name

I think it is ok to keep, but let's change the error message so that it does not suggest adding setup.py. Maybe:

             f"The Python package `{module}` is not a valid package, " 
             "it does not specify a `name` in `pyproject.toml` nor has a legacy `setup.py` file." 

[krassowski]

Thanks!

[krassowski]

Is the CI failure related to my change?

[bollwyvl]

PyPI is having a bad day.

Also adding --disable-pip-version-check (or setting PIP_DISABLE_PIP_VERSION_CHECK) when upgrading pip can cut down a lot on the noise.

[krassowski]

Yes but besides it, the tests which run:

FAILED tests/test_tpl.py::test_builder_version_mismatch - AssertionError: Expected version mismatch error message not found in output!
assert None
 +  where None = <function search at 0x1010be980>('ValueError: Extensions require a devDependency on @jupyterlab/builder@\\^.+?, you have a dependency on 4\\.0\\.0', 'Building extension in /private/var/folders/8d/778wjbv96mq1760tv6gk374m0000gn/T/pytest-of-runner/pytest-0/test_builder...g file for details: jupyterlab-debug.log\n  warnings.warn(f"See the log file for details: {log_path}", stacklevel=1)\n')
 +    where <function search at 0x1010be980> = re.search
 +    and   'Building extension in /private/var/folders/8d/778wjbv96mq1760tv6gk374m0000gn/T/pytest-of-runner/pytest-0/test_builder...g file for details: jupyterlab-debug.log\n  warnings.warn(f"See the log file for details: {log_path}", stacklevel=1)\n' = CalledProcessError(1, ['jupyter-builder', 'build', '/private/var/folders/8d/778wjbv96mq1760tv6gk374m0000gn/T/pytest-of-runner/pytest-0/test_builder_version_mismatch0/ext', '--core-version', '4.5.x']).stderr
 +      where CalledProcessError(1, ['jupyter-builder', 'build', '/private/var/folders/8d/778wjbv96mq1760tv6gk374m0000gn/T/pytest-of-runner/pytest-0/test_builder_version_mismatch0/ext', '--core-version', '4.5.x']) = <ExceptionInfo CalledProcessError(1, ['jupyter-builder', 'build', '/private/var/folders/8d/778wjbv96mq1760tv6gk374m0000gn/T/pytest-of-runner/pytest-0/test_builder_version_mismatch0/ext', '--core-version', '4.5.x']) tblen=2>.value

[bollwyvl]

Ah, didn't get that far. Perhaps try:

pytest -vv --tb=long --color=yes

... for more glorious technicolor ✖️

Also, for debugging CI stuff, pytest-html (and archiving it always()) helps a lot.

[Darshan808]

#115 fixes the CI