Patch to fully support @jupyterlab/builder#98
Merged
Conversation
Member
Author
|
We have a backward compatibility check, but it only tests for version mismatch error and does not test a successful build with jupyter-builder/tests/test_tpl.py Lines 189 to 228 in 376a532 |
Member
Author
|
I added same tests to #99 as well and we can verify that currently
But the same tests passes here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #81
Description
Downstream extensions that download latest
jupyterlabbut do not yet depend upon@jupyter/builderand still only depend upon@jupyterlab/builderare having trouble building due to some design modification injupyter-builder.This PR adds a patch to support
@jupyterlab/buildertoo.