Skip to content

Conversation

@brichet
Copy link
Collaborator

@brichet brichet commented Sep 9, 2025

This PR allows a custom notification for a "writing" user.

Fixes #263

Changes

@jupyter/chat

  • the ChatModel.IWriter interface allows a typingIndicator?: string, which is used in place of the default 'is writing' indication
  • the chat widget has a new property called writerComponent, that can contain a react component to display after each user writing notification

jupyterlab-chat

  • the user structure in the document awareness can be populated with an optional typingIndicator when the isWriting property is set
  • a new plugin provides the writerComponent object, to allow third party extensions to add a component.

Example

Using of the new indicator and component with jupyter-ai.

output.webm

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

Binder 👈 Launch a Binder on branch brichet/jupyter-chat/custom_typing_notification

@jtpio jtpio added the enhancement New feature or request label Sep 10, 2025
@brichet brichet marked this pull request as ready for review September 11, 2025 14:50
@jtpio
Copy link
Member

jtpio commented Sep 16, 2025

Nice, thanks @brichet for working on this!

Looks like it picked up some conflicts, likely after the merge of #262.

@brichet
Copy link
Collaborator Author

brichet commented Sep 16, 2025

Looks like it picked up some conflicts, likely after the merge of #262.

Indeed.
I'll wait for #275 to be merged before fixing it, to avoid future conflicts.

@brichet brichet force-pushed the custom_typing_notification branch from 8496348 to c4a6b68 Compare September 17, 2025 08:57
@brichet brichet force-pushed the custom_typing_notification branch from c4a6b68 to ea1f5aa Compare September 17, 2025 09:00
@brichet brichet requested a review from dlqqq October 9, 2025 12:21
@brichet
Copy link
Collaborator Author

brichet commented Nov 3, 2025

There are some conflicts after #298.
Fixing #301 will probably fix/add some conflicts, so we should probably wait for it before fixing the conflicts here.

@brichet brichet self-assigned this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Allow extensions to control the status indicator

2 participants