Shrink name of the chat if too big #332
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
brichet
reviewed
Dec 17, 2025
packages/jupyter-chat/style/chat.css
Outdated
| } | ||
|
|
||
| .jp-chat-open { | ||
| max-width: calc(100% - 140px); |
Collaborator
There was a problem hiding this comment.
Where does this 140px value come from ?
Should it be computed dynamically instead ?
Contributor
Author
There was a problem hiding this comment.
I find 140px more suitable for current width of chat. And yes we can use dynamic width instead.
packages/jupyter-chat/style/chat.css
Outdated
| overflow: hidden; | ||
| } | ||
|
|
||
| .lm-AccordionPanel-titleLabel { |
Collaborator
There was a problem hiding this comment.
We should probably be more specific on the selector, to avoid targeting other DOM elements in the page.
Contributor
Author
There was a problem hiding this comment.
Yes I will done this by adding another parent class.
Contributor
Author
|
Hey @brichet I have also updated the pr description video. Can you have a look on it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shrink name of the chat if too big.
Screencast.From.2025-12-18.21-57-38.mp4
📚 Documentation preview: jupyter-chat--332.org.readthedocs.build/en/332
💡 JupyterLite preview: jupyter-chat--332.org.readthedocs.build/en/332/lite/lab/index.html