Fix Enter key submitting message during IME composition#407
Open
aisensiy wants to merge 3 commits into
Open
Conversation
When using CJK input methods (Chinese, Japanese, Korean), pressing Enter to confirm an IME candidate incorrectly submits the chat message. This adds checks for `event.isComposing` and `event.keyCode === 229` to ignore Enter key events during IME composition.
Contributor
|
|
nakul-py
suggested changes
Apr 13, 2026
Co-authored-by: Nakul Verma <nakulverma.py@gmail.com>
Co-authored-by: Nakul Verma <nakulverma.py@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using an Input Method Editor (IME) — such as Chinese Pinyin, Japanese, or Korean — pressing Enter to confirm a candidate character incorrectly submits the chat message instead of completing the IME composition.
This adds checks for
event.isComposingandevent.keyCode === 229to ignore Enter key events during IME composition in two places:chat-input.tsx— the main chat inputmultichat-panel.tsx— the chat selector search inputReproduce
jupyterin the chat input — the IME shows a candidate listFix
During IME composition, the browser fires
keydownevents withevent.isComposing === true(andevent.keyCode === 229for legacy compatibility). These are now detected and ignored so Enter only sends the message outside of IME composition.References: MDN: KeyboardEvent.isComposing