[Bug] Launcher ignores configured defaultDirectory when creating chats#421
Open
Zsailer wants to merge 1 commit into
Open
[Bug] Launcher ignores configured defaultDirectory when creating chats#421Zsailer wants to merge 1 commit into
Zsailer wants to merge 1 commit into
Conversation
Contributor
|
|
Previously, only chats created from the side panel respected the configured defaultDirectory. Chats created from the launcher, menu, or command palette used the file browser's current directory instead. Now all paths use defaultDirectory when one is configured, falling back to the file browser path only when no default is set. Adds a UI test verifying that the launcher creates chats in the configured directory.
Zsailer
force-pushed
the
fix/launcher-uses-default-directory-oss
branch
from
a14e121 to
d55ab3b
Compare
Collaborator
|
Thanks @Zsailer for working on this. This PR seems to revert the behavior introduced in #238, so I believe that it was expected. cc. @andrii-i @ellisonbg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
defaultDirectoryis configured (via settings or server config), chats created from the side panel correctly land in that directory. But chats created from the launcher, menu, or command palette ignore it and use the file browser's current directory instead.The
createChatcommand was only checkinginSidePanelto decide whether to use the configured directory. Now it also checks whether adefaultDirectoryis configured -- if one exists, it's used regardless of where the chat was created from. The file browser fallback only kicks in when no default is configured.Includes a UI test that configures a default directory, creates a chat from the launcher, and verifies it lands in the right place.