replaces / by PreferredPath + .jupyter/ as the default directory if available#422
Open
jhgoebbert wants to merge 4 commits into
Open
replaces / by PreferredPath + .jupyter/ as the default directory if available#422jhgoebbert wants to merge 4 commits into
/ by PreferredPath + .jupyter/ as the default directory if available#422jhgoebbert wants to merge 4 commits into
Conversation
Contributor
|
|
krassowski
added
enhancement
brichet
reviewed
May 3, 2026
brichet
left a comment
brichet
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @jhgoebbert for working on this.
Do you think that you can add a test on this change ?
| // area (launcher, menu, palette). | ||
| if (targetDirectory === undefined) { | ||
| const hasPreferredPath = PageConfig.getOption('preferredPath'); | ||
| const preferredPath = hasPreferredPath |
Collaborator
There was a problem hiding this comment.
Should we check that preferredPath exists ?
| if (targetDirectory === undefined) { | ||
| const hasPreferredPath = PageConfig.getOption('preferredPath'); | ||
| const preferredPath = hasPreferredPath | ||
| ? hasPreferredPath + '/.jupyter/' |
Collaborator
There was a problem hiding this comment.
.jupyter is more for configuration file I think, not sure if this is relevant for chat files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
/byPreferredPath + .jupyter/(if available) as the default directory for chat-files if defaultDirectory is not set or empty.It is a possible solution for the issue #411