Add dialog to update user info #482
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
davidbrochart
approved these changes
May 7, 2025
krassowski
reviewed
May 7, 2025
krassowski
reviewed
May 7, 2025
| justify-content: space-between; | ||
| } | ||
|
|
||
| .jp-UserInfo-Field > * { |
There was a problem hiding this comment.
Can the * be replaced with a more precise selector? * has negative performance implications as every DOM element will be evaluated against the path.
There was a problem hiding this comment.
I updated it with the expected tags.
Co-authored-by: Michał Krassowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the user to update its attributes name, display_name, initials, color and avatar_url.
The updatable fields are send by the server, starting from jupyter-server/jupyter_server#1518.
It is backward compatible, the fields will not be updatable if the property is not provided by the server.
record-2025-05-07_07.58.20.webm
Fixes:
TODO